011.Container With Most Water (java) #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanglbme
reviewed
Oct 30, 2018
| @@ -0,0 +1,18 @@ | |||
| class Solution { | |||
| public int maxArea(int[] height) { | |||
| int start = 0, end = height.length - 1, maxArea = 0; | |||
Member
There was a problem hiding this comment.
虽然题目没有说明是否有非空的情况，但如果从程序健壮性/实际应用的角度来看，加以下一小段代码是有必要的噢~
if (height == null || height.length < 2) {
return 0;
}否则当传入 null 时，程序直接抛 NPE。
Member
Author
There was a problem hiding this comment.
image
题目中恰好有提到 数组长度至少为2。
Member
|
@bluesword12350 |
Member
Author
|
@yanglbme 多谢，其实考虑单个函数的健壮性，还是应该加上，不过现在开发多了分布式系统，一些参数在多个服务间流转，如果每个去检测的话，会出现参数重复检测的问题，我一般都是在入口进行统一参数验证，之后都默认参数合格的。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None.